feat: Add reject dlc channel offer handling #199
Conversation
This change allows the counterparty to reject a dlc channel offer and adds a handling to gracefully transition the dlc channel to a `Cancelled` state.
Set offered contract state to rejected
holzeis
force-pushed
the
feat/add-reject-dlc-channel-offer-handling
branch
from
f19a1c6 to
19b0e87
Compare
Set offered contract to rejected on offering side
Only unreserve utxos on the offering side.
oh you've merged it already 😅 . I would have cleaned up the fixups, before merging.. :) |
Somehow I thought github was clever enough to squash them on merge, I guess I keep expecting too much from them... |
Can't tell if this is sarcasm but there is a way to squash and merge. just click the green drop down arrow next to "rebase and merge" and choose "squash and merge" instead. |
|
Yeah squashing is not really what I want to, I'd like it to do an autosquash, but I guess that's too much to ask :) |
|
What's the difference between squashing and auto squashing?
|
|
Auto-squashing is an option to rebase that put automatically squashes the fixup commits. See e.g. here: https://thoughtbot.com/blog/autosquashing-git-commits |
|
hmm, cool. Thanks! |
This change allows the counterparty to reject a dlc channel offer and adds a handling to gracefully transition the dlc channel to a
Cancelledstate.Not super critical, but IMHO it makes it a bit clearer if the dlc channel offer is stuck or rejected.